test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual#10072
Closed
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:test-http-unix-socket-patch
Closed
test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual#10072davidmarkclements wants to merge 1 commit intonodejs:masterfrom davidmarkclements:test-http-unix-socket-patch
davidmarkclements wants to merge 1 commit intonodejs:masterfrom
davidmarkclements:test-http-unix-socket-patch
Conversation
Member
|
LGTM other than the commit message should follow these rules |
Member
Author
|
@santigimeno specifically the column count or is there also something else? |
Member
|
@davidmarkclements also the format: |
davidmarkclements
changed the title
mcollina
reviewed
Dec 1, 2016
Member
There was a problem hiding this comment.
while we are editing this, can you please use common.mustCall in those two functions?
addaleax
added
the
code-and-learn
cjihrig
requested changes
Dec 3, 2016
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
It might be good to replace the req.on('error', ...) handler if common.fail() instead of explicitly calling process.exit().
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings.
Member
|
@cjihrig @mcollina I've made changes per your comments and force pushed them to @davidmarkclements's branch. PTAL. |
Member
addaleax
approved these changes
Dec 8, 2016
cjihrig
approved these changes
Dec 8, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2016
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings. PR-URL: nodejs#10072 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Member
|
Landed in 444b907. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings. PR-URL: #10072 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2017
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings. PR-URL: #10072 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
added
dont-land-on-v4.x
and removed
code-and-learn
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings. PR-URL: #10072 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Use `common.mustCall()` and `common.fail()` where appropriate. Change `assert.equal` to `assert.strictEqual` to ensure specificity. Change var declarations to const to take advantage of ES6 immutable bindings. PR-URL: #10072 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, crypto
Description of change
changes
assert.equaltoassert.strictEqualto ensure specificitychanges var declarations to const to take advantage of es6 immutable bindings
edit: correct subsystem